Inconsistent formatting for unary operators

[eschnett]

The code below is the result of formatting several lines where x is prefixed by a sequence of unary operators (+ and \star). In the input, there was no white space between the operators. JuliaFormatter seems to misinterpret the unary operators as binary operators.

            ++ + x == 0
            ++ ++ x == 0
            ⋆⋆x == 0
            ⋆⋆ ⋆ x == 0
            ⋆⋆ ⋆ ⋆x == 0

[domluna]

@eschnett can you post what the input, output and expected output would be? I'm pretty confused right now lol

[eschnett]

The input and expected output are both

            +++x == 0
            ++++x == 0
            ⋆⋆x == 0
            ⋆⋆⋆x == 0
            ⋆⋆⋆⋆x == 0

It's a variable x with multiple unary operators in front. There shouldn't be any spaces between them.

[domluna]

Hmm this might be an issue with CSTParser, the parsed CST looks a little weird

julia> CSTParser.parse("+++x == 0")
  1:9   BinaryOpCall
  1:5    BinaryOpCall
  1:2     OP: PLUSPLUS
  3:3     OP: PLUS
  4:5     x
  6:8    OP: EQEQ
  9:9    INTEGER: 0

I would think those would be UnaryOpCalls.

another 1

julia> CSTParser.parse("+++++x == 0")
  1:11  BinaryOpCall
  1:7    BinaryOpCall
  1:2     OP: PLUSPLUS
  3:4     OP: PLUSPLUS
  5:7     UnaryOpCall
  5:5      OP: PLUS
  6:7      x
  8:10   OP: EQEQ
 11:11   INTEGER: 0

ref julia-vscode/CSTParser.jl#206

[eschnett]

I didn't know where was a ++ operator. If there is, that parse might make sense.

However, there is still the other issue with the \star operators:

julia> CSTParser.parse("⋆⋆⋆⋆x")
  1:13  BinaryOpCall
  1:6    UnaryOpCall
  1:3     OP: STAR_OPERATOR
  4:6     OP: STAR_OPERATOR
  7:9    OP: STAR_OPERATOR
 10:13   UnaryOpCall
 10:12    OP: STAR_OPERATOR
 13:13    x

This parse is different that what Julia itself does:

julia> :(⋆⋆⋆⋆x) |> dump
Expr
  head: Symbol call
  args: Array{Any}((2,))
    1: Symbol ⋆
    2: Expr
      head: Symbol call
      args: Array{Any}((2,))
        1: Symbol ⋆
        2: Expr
          head: Symbol call
          args: Array{Any}((2,))
            1: Symbol ⋆
            2: Expr
              head: Symbol call
              args: Array{Any}((2,))
                1: Symbol ⋆
                2: Symbol x