Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors with Typescript 2.6 using --strictFunctionTypes #142

Open
desjardinsm opened this issue Dec 6, 2017 · 1 comment
Open

Errors with Typescript 2.6 using --strictFunctionTypes #142

desjardinsm opened this issue Dec 6, 2017 · 1 comment

Comments

@desjardinsm
Copy link

I should note that this is using version 1.11.9:

$ tsc --strictFunctionTypes
dojo/1.11/_base.d.ts(1853,4): error TS2411: Property ''text'' of type '(xhr: { responseText: string; }) => string' is not assignable to string index type '(xhr: { responseText?: string; responseXML?: string; }) => any'.
dojo/1.11/_base.d.ts(1854,4): error TS2411: Property ''json'' of type '(xhr: { responseText: string; }) => GenericObject' is not assignable to string index type '(xhr: { responseText?: string; responseXML?: string; }) => any'.
dojo/1.11/_base.d.ts(1855,4): error TS2411: Property ''json-comment-filtered'' of type '(xhr: { responseText: string; }) => GenericObject' is not assignable to string index type '(xhr: { responseText?: string; responseXML?: string; }) => any'.
dojo/1.11/_base.d.ts(1856,4): error TS2411: Property ''javascript'' of type '(xhr: { responseText: string; }) => any' is not assignable to string index type '(xhr: { responseText?: string; responseXML?: string; }) => any'.
dojo/1.11/_base.d.ts(1857,4): error TS2411: Property ''xml'' of type '(xhr: { responseXML: string; }) => Document' is not assignable to string index type '(xhr: { responseText?: string; responseXML?: string; }) => any'.
dojo/1.11/_base.d.ts(1858,4): error TS2411: Property ''json-comment-optional'' of type '(xhr: { responseText: string; }) => GenericObject' is not assignable to string index type '(xhr: { responseText?: string; responseXML?: string; }) => any'.
@dylans
Copy link
Member

dylans commented Dec 14, 2017

We definitely need to address this as part of the Dojo 2 - Dojo 1 interop story.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants