"RTL feature-detect" changes caused build simple dojo.js can't be loaded

[bright-sea]

After updated to latest dgrid, our after-build single layer dojo.js (include everything, dgrid as well) can't be loaded, the error is

the error was caused by recently change

35f9504#diff-bead9f16bff9aecbab8689853913bbcd

the problem happened at line:

put(document.body, element, ".dgrid-scrollbar-measure");

that element might be null.

This code works before build, but after build, most of time it will failed at this line, but sometimes it will ok and I can see element is not null.

I put a log statement before this line to print element, and found:

Sometimes, element is a div object and sometime it is an div node
when element is a div object, it will be failed. When element is a domnode like list below, it is Ok.

But sometime, element is a domnode like below, it will still be failed:

[bright-sea]

I had tried to rollback to preview commit version, and found that

if I rollback to March 25th, 2014 version:
1d29031
This issue is the same.

if I rollback to March 11th, 2014 version,
ccfd5be
everything is OK.

So this issue related to the code changes between these two date.

[kfranqueiro]

You've referenced quite a few commits here, and I'm not sure whether the ones referenced are actually the problem. I suspect that ab64e8e may be what caused the problem for you. Could you verify by testing after ab64e8e and before it (i.e. on 86ad71d)?

[bright-sea]

I will narrow it down to a particular commitment ASAP.

Thanks

Sent from my iPhone

On May 5, 2014, at 1:38 PM, "Kenneth G. Franqueiro" [email protected] wrote:

You've referenced quite a few commits here, and I'm not sure whether the ones referenced are actually the problem. I suspect that ab64e8e may be what caused the problem for you. Could you verify by testing after ab64e8e and before it (i.e. on 86ad71d)?

—
Reply to this email directly or view it on GitHub.

[bright-sea]

Yes, ken. It is exactly ab64e8e commit caused this issue.

[kfranqueiro]

@bright-sea, I've pushed a branch with an attempted fix to this issue. I haven't had immediate success reproducing the issue internally though, even with a build with dgrid included. Could you verify that the changeset I've pushed fixes the issue for you? Thanks!

[bright-sea]

@kfranqueiro , yes, this fix works. Thanks.