Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard mixin does not reset _focusedNode when the target is not active #899

Closed
ghost opened this issue Apr 17, 2014 · 2 comments
Closed

Comments

@ghost
Copy link

ghost commented Apr 17, 2014

In the Keyboard mixin the removeRow method sets _focusedNode to null with the expectation that the _restoreFocus method will reset it by calling focus.

However focus will not be called in the case where the _removedFocus object has active set to false. This is expected but means that _focusedNode does not set reset. Calling focus with no arguments on the grid after this will cause an exception.

@ghost
Copy link
Author

ghost commented Apr 17, 2014

The easy fix would be to add this._focusedNode = newTarget.element; after line 240 in Keyboard.js.

@ghost ghost closed this as completed in d6198d0 May 21, 2014
@kfranqueiro
Copy link
Member

Thanks for reporting this. I tested and added the fix you suggested.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant