OnDemandGrid, ColumnSet, and height: auto causes horizontal scrollbar to overlap with last row

[tryte]

When using an OnDemandGrid with a ColumnSet and applying height: auto CSS style (as in test/autoheight.html, the horizontal scrollbar of the column set overlaps with the content of the last row.

I'm not entirely certain how a testcase is supposed to look, but here's a diff gist which will apply the CSS styles mentioned above to test/complex_column.html#gridSingleRow.

I have tested this with Dojo 1.9.1 and dgrid v0.3.8 under current Chrome, Firefox and Internet Explorer and the issue is the same in those combinations. I'd guess this issue is not version specific.

Am I applying the correct CSS styles for my use case (which is very much the same as that of the autoheight testcase)?
Is the combination of autoheight and scrollable ColumnSets something that can (currently?) not be done?

[kfranqueiro]

This is resolved by 7ae43e0 in everything except IE6 (and even that is in a better state than prior to this commit).

Given how much time it took just to get to a solution that agreed with all other oldIEs, I'm inclined to leave it at that. dgrid 0.4 is dropping IE < 8, so this is resolved for all platforms we will be supporting in the future.

[kfranqueiro]

I forgot to clarify one thing: in order to benefit from this fix, you need to use the dgrid-autoheight class specifically for auto-height grids, since part of the fix involves an additional style based on that class.

[tryte]

Great to hear you've tackled this bug! I've not been allotted the time to test my scenario with your fix yet, but will report back lateron.

Regarding the support of Internet Explorer, is there some kind of roadmap or list of supported browsers and versions for each dgrid (plus dojo) version? As for dgrid 0.4, I've seen http://www.sitepen.com/blog/2014/04/29/looking-ahead-to-dgrid-0-4/ but dropping IE < 8 is not mentioned.

[kfranqueiro]

Thanks for bringing up that question, actually - I should add supported browsers to the README for 0.4 in particular. The decision to drop IE < 8 wasn't formalized internally on our end until probably the month after I wrote that post.

dgrid 0.3 supported IE6+ and we have been attempting to adhere to that, but admittedly IE6 and 7 can be particularly flaky in some respects, sometimes simply due to their behavior when rendering tables. (Heck, so can IE8, but we stil see plenty of people needing to support that, unfortunately.)

Dojo itself also supported IE6+ but as of 1.9, the committers stopped dedicating time to testing IE6 and IE7. No IE6-7 logic has been explicitly torn out of later versions of Dojo 1.x so it's still "unofficially" supported, but no new effort has gone into testing them.

For dgrid 0.4 I do plan to tear out any logic specific to IE < 8 to lighten the code. I had a branch for this a while ago but need to update it and merge it sometime soon.