Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a parent node with expanded child nodes in a tree is updated, child nodes are wrongly displayed. #550

Closed
jongeuncha opened this issue Apr 19, 2013 · 8 comments

Comments

@jongeuncha
Copy link

In test/tree_editor.html, expand Africa and Kenya

before

And run this in the console to update Africa node.

testCountryStore.put(testCountryStore.get("AF"))

And the expanded child nodes are wrongly displayed like below.

after

By examining DOM, height style of div that wraps Africa's children is 75px that is supposed to 125px.

This seems to be caused by wrongly treating Promise result of grid.renderArray() in grid.expand function in tree.js.
This gets messier when the store is JsonRest.

@runtarm
Copy link

runtarm commented Apr 19, 2013

Which browser and dgrid version do you use?

It didn't seems to reproducible on Chrome and dgrid 0.3.7.

@jongeuncha
Copy link
Author

Sorry to forget to mention that.
dgrid version is 0.3.7
It works in Chrome but does not work in firefox.

@justindoherty
Copy link
Contributor

In firefox there seems to be a height set for the dgrid-tree-container's div which does not seem to exist in chrome.
image
image

@runtarm
Copy link

runtarm commented Apr 20, 2013

That height seems to be a trigger for css-transition and will get removed when the transition has ended.

The problem is a transitionend event won't fire sometime in Firefox.

@mvaerle
Copy link

mvaerle commented Jun 16, 2014

We're having the same issue with Firefox only. There seems to be a race condition between the animation finishing and the response coming back from the server, but that's just from visually observing.

@kfranqueiro
Copy link
Member

Can you try this again against dgrid master and see if it's resolved? This sounds like it could be the same issue as #874.

@jongeuncha
Copy link
Author

This issue is tested on v0.3.15 and seems to be resolved.

@kfranqueiro
Copy link
Member

If it's resolved in 0.3.15 then I guess a prior revision might have already addressed your case. I was thinking something we checked into master yesterday might've fixed it.

Thanks for re-testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants