Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColumnReorder leaks memory when used with ColumnSet #396

Closed
kriszyp opened this issue Jan 21, 2013 · 0 comments · Fixed by #397
Closed

ColumnReorder leaks memory when used with ColumnSet #396

kriszyp opened this issue Jan 21, 2013 · 0 comments · Fixed by #397

Comments

@kriszyp
Copy link
Member

kriszyp commented Jan 21, 2013

The _destroyColumns method in ColumnReorder does not get called if ColumnSet overrides it, since it doesn't call this.inherited(arguments), so the column Dnd Sources are never destroyed when the grid is destroyed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Call this.inherited(arguments) in _destroyColumn so that cleanup takes p... kriszyp/dgrid
1 participant
@kriszyp