Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object values and editor plugin #304

Closed
phil0135 opened this issue Oct 8, 2012 · 1 comment
Closed

Object values and editor plugin #304

phil0135 opened this issue Oct 8, 2012 · 1 comment

Comments

@phil0135
Copy link

phil0135 commented Oct 8, 2012

First of all, it is great that dgrid supports objects in the underlying store, which makes displaying more complex data really flexible.

I use this feature within an editor grid and wrote a custom widget to modify the object. But when triggering the onChange event of my custom widget, the grid does not recognize the changed value.
The reason is the compare statement in editor.js on line 53.

Replacing the statement as seen below, seems to fix this. I tested this with some widgets (DateTextBox, NumberSpinner, TextBox, FilteringSelect) and it worked fine.
Is there another reason for not using the simple compare operator I hadn't recognized?

regards, Philipp

editor.js

-53:  if(!(oldValue >= value && oldValue <= value)){
+53: if(oldValue != value){
@ghost
Copy link

ghost commented Feb 12, 2013

This should be resolved by the referencing pull request.

@ghost ghost closed this as completed Feb 12, 2013
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant