Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed rows not filled in with Pagination extension #283

Closed
kriszyp opened this issue Sep 17, 2012 · 2 comments
Closed

Removed rows not filled in with Pagination extension #283

kriszyp opened this issue Sep 17, 2012 · 2 comments

Comments

@kriszyp
Copy link
Member

kriszyp commented Sep 17, 2012

When you use the Pagination extension with an Observable store, updates to the first and last row cause the rows to disappear, because the Observable assumes that an update that moves an object to the first or last position may actually belong to a different page. Also, if any of the rows are removed, the page no longer has the correct number of rows. The Pagination extension should probably do a query for another row to fill up the rest of the page, to deal with removed rows and the last row disappearing. For the first row disappearance, we may need to requery the whole page.

@kriszyp
Copy link
Member Author

kriszyp commented Nov 15, 2012

#343

@ghost
Copy link

ghost commented Dec 21, 2012

Fixed with 6603fca and 40b47a3

@ghost ghost closed this as completed Dec 21, 2012
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant