From 5d6a2fd6a42ada4dc50f3e2a64bdf43a201b4b5d Mon Sep 17 00:00:00 2001 From: "Kenneth G. Franqueiro" Date: Tue, 5 Mar 2013 10:11:54 -0500 Subject: [PATCH] Selection: don't bother calling allowSelect for deselection This avoids an issue with resetting columns while something is selected; it also short-circuits unnecessary logic, since if it's not possible to select a row, it should always be deselected anyway. --- Selection.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Selection.js b/Selection.js index 39ce0a3fb..41cccb621 100644 --- a/Selection.js +++ b/Selection.js @@ -332,7 +332,7 @@ return declare(null, { if(!row.element){ row = this.row(row); } - if(this.allowSelect(row)){ + if(!value || this.allowSelect(row)){ var selection = this.selection; var previousValue = selection[row.id]; if(value === null){