This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Forward compatible updates for TS 2.4 #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm... I think I have configured appveyor to ignore branches that don't have a configuration file for appveyor and should stop these from being marked failed. |
agubler
reviewed
Jun 27, 2017
src/async/ExtensiblePromise.ts
Outdated
| const e: Executor<U> = (resolve, reject) => { | ||
| function handler(rejected: boolean, valueOrError: T | U | Error) { | ||
| const callback: ((value: T | U | Error) => (U | Thenable<U> | void)) | undefined = rejected ? onRejected : onFulfilled; | ||
| then<TResult1 = T, TResult2 = never>(onFulfilled?: ((value: T) => TResult1 | PromiseLike<TResult1>) | undefined | null, onRejected?: ((reason: any) => TResult2 | PromiseLike<TResult2> | void) | undefined | null): ExtensiblePromise<TResult1 | TResult2> { |
agubler
reviewed
Jun 27, 2017
src/async/ExtensiblePromise.ts
Outdated
| function handler(rejected: boolean, valueOrError: T | U | Error) { | ||
| const callback: ((value: T | U | Error) => (U | Thenable<U> | void)) | undefined = rejected ? onRejected : onFulfilled; | ||
| then<TResult1 = T, TResult2 = never>(onFulfilled?: ((value: T) => TResult1 | PromiseLike<TResult1>) | undefined | null, onRejected?: ((reason: any) => TResult2 | PromiseLike<TResult2> | void) | undefined | null): ExtensiblePromise<TResult1 | TResult2> { | ||
| const e: Executor<TResult1> = (resolve, reject) => { |
There was a problem hiding this comment.
I know it was e before but we could probably give it a better name.
agubler
approved these changes
Jun 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug / feature
The following has been addressed in the PR:
Description:
This PR contains forward compatible updates for TypeScript 2.4
Refs: dojo/meta#189