Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

Unnecessary generic parameter for Task.race #316

Open
jason0x43 opened this issue Apr 8, 2017 · 0 comments
Open

Unnecessary generic parameter for Task.race #316

jason0x43 opened this issue Apr 8, 2017 · 0 comments

Comments

@jason0x43
Copy link
Member

Bug

Task.race takes two generic parameters, an ExtensiblePromise subclass and the type expected to be the resolution of the race call. The first parameter is unnecessary as it is never used within the Task class.

Package Version: beta1

Code

const task = Task.race<void>([ ... ]);

Expected behavior:

This should compile.

Actual behavior:

TS complains that the call signature is invalid. The following does compile:

const task = Task.race<Task<void>, void>([ ... ]);
@dylans dylans added the bug label Apr 10, 2017
@dylans dylans added this to the 2017.04 milestone Apr 10, 2017
@dylans dylans modified the milestones: 2017.04, 2017.05 Apr 29, 2017
@eheasley eheasley modified the milestones: 2017.05, 2017.06, 2017.07 Jun 6, 2017
@kitsonk kitsonk added the beta3 label Jul 27, 2017
@kitsonk kitsonk modified the milestones: 2017.08, 2017.07 Jul 27, 2017
@kitsonk kitsonk modified the milestones: 2017.08, 2017.09 Sep 4, 2017
@dylans dylans modified the milestones: 2017.09, 2017.10 Oct 10, 2017
@kitsonk kitsonk added rc and removed beta3 labels Oct 10, 2017
@kitsonk kitsonk modified the milestones: 2017.10, 2017.12 Oct 10, 2017
@agubler agubler removed the rc label Jan 4, 2018
@dylans dylans modified the milestones: 2017.12, 2018.01 Jan 17, 2018
@dylans dylans removed this from the 2018.01 milestone Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants