Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to save command line options to the dojorc #255

Closed
wants to merge 7 commits into from

Conversation

JamesLMilner
Copy link
Contributor

Type: feature

The following has been addressed in the PR:

Description:

@agubler already wrote this but it is not in line with latest master. This should solve that.

Resolves #211

@JamesLMilner
Copy link
Contributor Author

JamesLMilner commented Oct 4, 2018

screenshot_20181004_214845

I changed this to support showing --save in the help feedback

EDIT: @agubler let me know what you think

Copy link
Contributor

@rorticus rorticus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #255 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
+ Coverage   98.13%   98.17%   +0.04%     
==========================================
  Files          21       21              
  Lines         965      988      +23     
  Branches      183      188       +5     
==========================================
+ Hits          947      970      +23     
  Misses         18       18              
Impacted Files Coverage Δ
src/help.ts 100.00% <100.00%> (ø)
src/registerCommands.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d9d4de...d218b2d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --save-args flag to write new command defaults to dojorc
3 participants