Fix bugs introduced in #416 #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| test: /\.(js|css|html|svg)$/, | ||
| cache: false | ||
| } | ||
| ) |
There was a problem hiding this comment.
Changing plugin options always invalidate cache
There was a problem hiding this comment.
I've added a comment on the other issue
agubler
pushed a commit
to agubler/cli-build-app
that referenced
this pull request
Jul 22, 2020
4 tasks
agubler
added a commit
that referenced
this pull request
Jul 22, 2020
* Fix bugs introduced in #416 (#419) * Fix brotli compression to output correct suffix. * Compressed files reported with blue size, and gzipped size not re-calculated. * deps Co-authored-by: Will Stott <[email protected]>
|
@willstott101 this should be released in 7.0.3 if you want to give it a try? |
This was referenced Apr 13, 2021
This was referenced Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I didn't properly test the previous MR. The compression plugin isn't as clever as I hoped and you have to specify the file name. Furthermore I've decided to disable cache due to webpack-contrib/compression-webpack-plugin#170 which was quite a headache during testing.
To make the bugs I introduced a bit less painful I decided to update the CLI marginally for compressed outputs too.
So we don't try to get the gzipped size of already compressed otuputs.