Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not forward SIGURG to the child process #34

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Do not forward SIGURG to the child process #34

merged 1 commit into from
Sep 6, 2023

Commits on May 26, 2023

  1. Do not forward SIGURG to the child process 

    Since go 1.14, SIGURG is emitted internally by the fo runtime, see:

- golang/go#37942
- https://go.googlesource.com/proposal/+/master/design/24543-non-cooperative-preemption.md#other-considerations "Choosing a signal"

This causes two problems:
- This will interfere with processes that use SIGURG for a real purpose (though this is unlikely)
- If SIGURG is emitted after the child process has exited but before secrets-init, there will be a spurious error message (see doitintl#16)
    @n-e
    n-e committed May 26, 2023
    Configuration menu
    Copy the full SHA
    10faccf View commit details
    Browse the repository at this point in the history