New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not forward SIGURG to the child process #34

Merged

alexei-led merged 1 commit into doitintl:master from n-e:do-not-forward-sigurg

Sep 6, 2023

Contributor

n-e commented May 26, 2023 •

edited by golinks bot

Loading

Since go 1.14, SIGURG is emitted internally by the fo runtime, see:

This causes two problems:

This will interfere with processes that use SIGURG for a real purpose (though this is unlikely)
If SIGURG is emitted after the child process has exited but before secrets-init, there will be a spurious error message (see Sometimes I get a "ERRO[0000] failed to send system signal to the process" #16)


          Do not forward SIGURG to the child process

10faccf

Since go 1.14, SIGURG is emitted internally by the fo runtime, see:

- golang/go#37942
- https://go.googlesource.com/proposal/+/master/design/24543-non-cooperative-preemption.md#other-considerations "Choosing a signal"

This causes two problems:
- This will interfere with processes that use SIGURG for a real purpose (though this is unlikely)
- If SIGURG is emitted after the child process has exited but before secrets-init, there will be a spurious error message (see doitintl#16)

alexei-led approved these changes

View reviewed changes

alexei-led merged commit 6b56dca into doitintl:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet