Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel disappears #294

Closed
josafath59 opened this issue Oct 31, 2022 · 6 comments
Closed

Carousel disappears #294

josafath59 opened this issue Oct 31, 2022 · 6 comments
Assignees
Labels
bug Something isn't working needs review The issue has been solved, Wait for confirmation. P1

Comments

@josafath59
Copy link

Describe the bug

Well my problem is the following: Carousel disappears for a moment it renders and then it disappears, if for example I put a View inside the Carousel and save the changes it renders again but I reload my application again it disappears in the same way if I remove that View then Caroulsel reappears but when I reload the same thing happens again it disappears.

Within my Project I am using another Carousel but that has no problem I tried to replicate it but I have not been successful it continues to disappear even though they have the same attributes

I hope you can help me

Expected behavior

Don't let the Carousel disappear

Screenshots

1
This is the Carousel code that renders and immediately disappears

2
This is the Carousel code that does not have a problem that does not disappear

WhatsApp Image 2022-10-31 at 11 33 01 AM
Here I show how nothing appears in the carousel

WhatsApp Image 2022-10-31 at 11 32 46 AM

This is what I would expect not to disappear even though I refresh the app

Versions (please complete the following information):

  • react: v 18.0.0
  • react-native: v 0.69.5
  • react-native-reanimated: v ~2.9.1
  • react-native-reanimated-carousel: v ^3.1.1
  • react-native-gesture-handler: v ~2.5.0

Smartphone (please complete the following information):

  • Device: [Black Shark 4]
  • OS: [Android 11]
  • Browser [Brave]
  • Version [1.45.116]

Additional context

Before I used an older version of react-native-reanimated-carousel and the carousel did not disappear, the problem was that when I generated the apk with eas build, this apk did have the problem that it disappeared, I even removed the ImageBackground component but without success keeps disappearing, it was also tested on an Iphone 12 in the same way the carousel disappears

@josafath59 josafath59 added the bug Something isn't working label Oct 31, 2022
@wfern
Copy link

wfern commented Nov 1, 2022

I can confirm this issue, everything works fine on 3.1.0 but not after update to the 3.1.1. It happens when the initial data is empty and then is filled. I said that because if the data is "static" or the component is rendered without coming from empty works fine.

If you add a condition to only render when the data is not empty, works fine too, e.g:

{data.length > 0 && (
  ...
)}

@josafath59 please, try it and confirm if it works for you too.

I tried to find the reason and patch-package it but no luck.

@jamninetyfive
Copy link

same issue here . then @wfern work fine thanks.

@dohooo
Copy link
Owner

dohooo commented Nov 1, 2022

Sorry, I've been working all day. I am really busy. It's a little tiring for me to maintain this project right now. 😞
Released in 3.1.2, and tell me the result, please. thx

@dohooo dohooo added P1 needs review The issue has been solved, Wait for confirmation. labels Nov 1, 2022
@dohooo dohooo closed this as completed in b49715c Nov 1, 2022
@wfern
Copy link

wfern commented Nov 1, 2022

It works @dohooo, thank you very much for everything!

@josafath59
Copy link
Author

Hello yes it worked thank you very much @wfern

I hope you are more relaxed soon @dohooo

@jamninetyfive
Copy link

@dohooo 没事,你偶尔关注下就好,辛苦,看来又是996受害者😋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs review The issue has been solved, Wait for confirmation. P1
Projects
None yet
Development

No branches or pull requests

4 participants