Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WHY WIDTH MUST BE DEFINED ?? #286

Closed
putuoka opened this issue Oct 20, 2022 · 3 comments
Closed

WHY WIDTH MUST BE DEFINED ?? #286

putuoka opened this issue Oct 20, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@putuoka
Copy link

putuoka commented Oct 20, 2022

please make the width auto base on the container width/flex just like height:0
it's easier to make it auto
Thank You.

@putuoka putuoka added the enhancement New feature or request label Oct 20, 2022
@dohooo
Copy link
Owner

dohooo commented Oct 20, 2022

There have some issues that I haven't solved. But PR welcome.
#268
image

Maybe I'll solve it soon.

@dohooo dohooo closed this as completed Oct 20, 2022
@putuoka
Copy link
Author

putuoka commented Dec 2, 2022

Hello @dohooo is this fix? can i use width 100% now?

<Carousel width={'100%'}/>

OR

const baseOptions = isVertical
    ? ({
        vertical: true,
        width: PAGE_WIDTH,
        height: PAGE_WIDTH / 2,
      } as const)
    : ({
        vertical: false,
        width: '100%',
        height: 0,
      } as const);


@dohooo
Copy link
Owner

dohooo commented Dec 2, 2022

No, not yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants