Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an internal defaults package. #177

Open
jmalloc opened this issue Apr 18, 2020 · 0 comments
Open

Create an internal defaults package. #177

jmalloc opened this issue Apr 18, 2020 · 0 comments

Comments

@jmalloc
Copy link
Member

jmalloc commented Apr 18, 2020

There are a lot of default values strewn throughout various sub-packages that interplay or are related in some way. They are also sort of duplicated in the infix package so that they appear in documentation and can be used to build the engine and network options.

It would be good to be able to see them in one place and define them in terms of each other.

We can do that in an internal package full of constants/variables, and reference this new package from both infix and the more specific packages.

This would be a good time to audit all of the default values too. For example, sql.DefaultMaxIdleConns is set to runtime.GOMAXPROCS(0) but should probably default to the same value as the concurrency limit which will likely be able to be considerably higher since the engine is certainly IO bound.

@jmalloc jmalloc added this to the 1.0.0 - Production milestone Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant