Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a ledger projection for the view ledger UI #32

Open
koden-km opened this issue Nov 18, 2019 · 4 comments
Open

Create a ledger projection for the view ledger UI #32

koden-km opened this issue Nov 18, 2019 · 4 comments

Comments

@koden-km
Copy link
Member

Data:

  • accountId
  • transactionId
  • transaciton type (transaction type: deposit, withdraw, transfer)
  • amount
  • description (need this? "success", "failed insufficient funds", "transfered to bob")
@jmalloc
Copy link
Member

jmalloc commented Nov 18, 2019

  • description (need this? "success", "failed insufficient funds", "transfered to bob")

A ledger in a bank typically only shows successful transactions anyway, but the description is probably where you'd put the transaction type in a "real" bank.

@koden-km
Copy link
Member Author

Depends if you want to filter on the transaciton type? Transfers are really the only one that needs something extra to say who it sent it to? Thats why I was leaning towards needing some kind of description. Fair enough on it only having successful transactions though.

@jmalloc
Copy link
Member

jmalloc commented Nov 18, 2019

I don't think we should bother with any filtering for the example.

@jmalloc
Copy link
Member

jmalloc commented Nov 18, 2019

Also, in an actual bank, there is still a description for deposit/withdrawal... it'll usually say something like BRANCH DEPOSIT (as opposed to, say, EFTPOS PURCHASE <merchant> or similar).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants