Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean and string need to render custom type names. #6

Closed
jmalloc opened this issue Jan 20, 2019 · 0 comments
Closed

Boolean and string need to render custom type names. #6

jmalloc opened this issue Jan 20, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@jmalloc
Copy link
Member

jmalloc commented Jan 20, 2019

Type names are always omitted for the reflect.String and reflect.Bool kind, because the I considered these literals always to be unambiguous, however this is not true when the type is not the default string or bool, but rather some user-defined type.

@jmalloc jmalloc added the bug Something isn't working label Jan 20, 2019
@jmalloc jmalloc closed this as completed in c9df38c Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant