Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testGGPlot tests too rigorious with the all.equal function in the scale testing section #52

Open
gubogaer opened this issue Oct 22, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@gubogaer
Copy link
Collaborator

The following dataframes are not equal in the current implementation

plot1<- dataframe %>%
    ggplot(aes(column1, column2)) +
    scale_x_log10('column1')

plot2<- dataframe %>%
    ggplot(aes(column1, column2)) +
    scale_x_log10()

yet they generate the exact same plot, this is caused by the all.equal function which is not suited for this.
this bug was first noticed in this dodona question

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant