Add polyline as allowed svg tag

[jorg-vr]

This pull request adds the 'poluline' tag as an allowed tag. This tag is used in SVG's by the turtle judge.

[coderabbitai]

Walkthrough

The changes involve modifications to the ApplicationHelper module found in app/helpers/application_helper.rb. The primary update is to the sanitize method, where the allowed tags list has been adjusted by replacing the polygon tag with the polyline tag. This alteration impacts the HTML sanitization process, specifically regarding the SVG elements that can be included in the sanitized output. No other methods were altered, and the overall structure and functionality of the helper methods remain unchanged.

Changes

File Path	Change Summary
app/helpers/application_helper.rb	Updated sanitize method: replaced polygon with polyline in allowed tags.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ApplicationHelper
    User->>ApplicationHelper: Call sanitize(html)
    ApplicationHelper->>ApplicationHelper: Process allowed tags
    ApplicationHelper->>ApplicationHelper: Replace `polygon` with `polyline`
    ApplicationHelper->>User: Return sanitized output

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between d882927 and dd6d99d.

📒 Files selected for processing (1)

• app/helpers/application_helper.rb (1 hunks)

🧰 Additional context used

🔇 Additional comments (2)

app/helpers/application_helper.rb (2)

Line range hint 1-324: Overall assessment: Change is minimal and focused.

The modification to the sanitize method is the only change in this file. It's a targeted update that addresses the PR objective without introducing unnecessary alterations. The rest of the helper methods remain unchanged, which helps maintain the overall stability of the module.

---

138-138: LGTM! Verify if 'polygon' removal is intentional.

The change aligns with the PR objective of adding 'polyline' as an allowed SVG tag. This is a minimal and focused change, which is good for maintainability.

Please verify if the removal of 'polygon' from the allowed tags is intentional, as it might have unintended consequences if it was being used elsewhere in the project.

Also, consider updating any documentation that might mention the allowed SVG tags.

✅ Verification successful

---

---

Verified: 'polygon' is no longer used within SVG contexts in the codebase.

No further action is required.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for 'polygon' usage in SVG context
rg --type=ruby --type=html --type=js 'polygon.*svg'

Length of output: 53

---

Script:

#!/bin/bash
# Improved search for 'polygon' usage in SVG contexts across various file types

# Search in Ruby, HTML, JS, CSS, and XML files for 'polygon' within SVG elements
rg --type=ruby --type=html --type=js --type=css --type=xml '<svg[^>]*>.*\bpolygon\b.*<\/svg>' -i

Length of output: 223

---

Script:

#!/bin/bash
# Corrected search for 'polygon' usage in SVG contexts across various file types

# Search in Ruby, HTML, JS, CSS, and XML files for 'polygon' within SVG elements
rg --type=ruby --type=html --type=js --type=css --type=xml '<svg[^>]*>.*\bpolygon\b.*</svg>' -i

Length of output: 97

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.