-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sentry release information #5582
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the rational for guarding against missing environment/release tags? I would assume that if they are missing, this should be an error, but I can also see not wanting to break all JavaScript just because these tags are missing
Co-authored-by: Niko Strijbol <[email protected]>
Co-authored-by: Niko Strijbol <[email protected]>
If there is an issue with the tags, 'there should be an error' indeed Now those errors will be logged under 'unknown'. Seeing 'unknown' in sentry should trigger us to wonder why we didn't get the information |
This pull request adds release information to sentry. It also takes the environment information from rails instead of recalculating it based on hostname.
It also removes the sending of release info to sentry, as the release name is now contained in the tag. And sourcemaps are already pushed upon build.
I have also loaded sentry within frames (where it wasn't present yet).