Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to enable submit button when not logged in #5580

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Jun 4, 2024

For some reason the error does not reproduce on my devise, which made it take a lot longer to debug.
But simply logging the the button showed it as null when not logged in.

When logged in, the button is always present.

Fixes DODONA-FRONTEND-9

@jorg-vr jorg-vr added the bug Something isn't working label Jun 4, 2024
@jorg-vr jorg-vr self-assigned this Jun 4, 2024
@jorg-vr jorg-vr requested a review from a team as a code owner June 4, 2024 12:49
@jorg-vr jorg-vr requested review from bmesuere and niknetniko and removed request for a team June 4, 2024 12:49
app/assets/javascripts/exercise.ts Outdated Show resolved Hide resolved
@jorg-vr jorg-vr requested a review from niknetniko June 4, 2024 13:06
@jorg-vr jorg-vr merged commit 4e32c0b into main Jun 4, 2024
11 of 13 checks passed
@jorg-vr jorg-vr deleted the fix/enableSubmit branch June 4, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants