Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to show timezone or iframe warning if not present #5573

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Jun 3, 2024

This pull request fixes #5572

I also applied the same fix for check Iframe, but I am open for discussion on that one, as we might want to get notified should that warning not be present when desired.

Closes #5572.

@jorg-vr jorg-vr added the bug Something isn't working label Jun 3, 2024
@jorg-vr jorg-vr self-assigned this Jun 3, 2024
@jorg-vr jorg-vr requested a review from a team as a code owner June 3, 2024 17:34
@jorg-vr jorg-vr requested review from bmesuere and niknetniko and removed request for a team June 3, 2024 17:34
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I don't think the second ?. on each line is needed but no harm down with including it.)

Did you see errors for checkIframe on Sentry?

@jorg-vr
Copy link
Contributor Author

jorg-vr commented Jun 3, 2024

We haven't yet encountered the iFrameIssue on sentry. It was just right below in the code, so my I fell upon it

And yes the second ?. is required

@bmesuere bmesuere changed the title Allow checkTimeZone to fail if warning is not present Don't try to show timezone or iframe warning if not present Jun 3, 2024
@jorg-vr jorg-vr merged commit efc5e45 into main Jun 4, 2024
14 of 15 checks passed
@jorg-vr jorg-vr deleted the fix/timezone-warning branch June 4, 2024 08:25
Copy link

sentry-io bot commented Jun 14, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: null is not an object (evaluating 'document.querySelector("#time-zone-warning").classList') checkTimeZone(app/assets/javascripts/utilities) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide timezone warning sometime errors
3 participants