Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken pythia submission if data is not present in group #5235

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Dec 13, 2023

This pull request fixes a dodona crash when it tries to render this submission: https://dodona.be/nl/submissions/14904216.json

The cause was data not being present in the group.

  • Tests were added

@jorg-vr jorg-vr added the bug Something isn't working label Dec 13, 2023
@jorg-vr jorg-vr self-assigned this Dec 13, 2023
@jorg-vr jorg-vr requested a review from a team as a code owner December 13, 2023 13:30
@jorg-vr jorg-vr requested review from bmesuere and chvp and removed request for a team December 13, 2023 13:30
@jorg-vr jorg-vr merged commit aab9b02 into main Dec 13, 2023
15 checks passed
@jorg-vr jorg-vr deleted the fix/pythia-renderer-bug branch December 13, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants