Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow python tutor for every judge #5050

Merged
merged 11 commits into from
Oct 23, 2023
Merged

Allow python tutor for every judge #5050

merged 11 commits into from
Oct 23, 2023

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Oct 19, 2023

This pull request allows the python tutor for every judge.

If a test case contains the following:

"data": {
  "statements": "", // A string containing the "test code"
  "stdin": "", // A string containing stdin
}

A link to the python tutor is added.

For pythia "files": {} // Map of names to their contents and other metadata, ignored for now. is also still supported, both to init file links and for the tutor.
It is not yet generalized as Tested is not yet ready to support it.
We will add this support in a future pr.

@jorg-vr jorg-vr added the feature New feature or request label Oct 19, 2023
@jorg-vr jorg-vr self-assigned this Oct 19, 2023
@jorg-vr
Copy link
Contributor Author

jorg-vr commented Oct 19, 2023

@niknetniko you can test your Tested implementation using this pr if you also run https://github.com/dodona-edu/python-tutor-webservice locally.

if you have a better suggestion for the fields I am open to that. Then I will simply add support for both and put the new names in the docs.

@niknetniko
Copy link
Member

Summary of my changes:

  • Add support for this for the partial output
  • Move the description in the full format to the context level (which I think is the correct level)

See dodona-edu/universal-judge#449 for the implementation in TESTed.

@jorg-vr jorg-vr marked this pull request as ready for review October 19, 2023 14:43
@jorg-vr jorg-vr requested a review from a team as a code owner October 19, 2023 14:43
@jorg-vr jorg-vr requested review from bmesuere and chvp and removed request for a team October 19, 2023 14:43
@bmesuere bmesuere added the deploy naos Request a deployment on naos label Oct 20, 2023
@bmesuere bmesuere temporarily deployed to naos October 20, 2023 09:30 — with GitHub Actions Inactive
@github-actions github-actions bot removed the deploy naos Request a deployment on naos label Oct 20, 2023
@bmesuere bmesuere added the deploy naos Request a deployment on naos label Oct 21, 2023
@bmesuere bmesuere temporarily deployed to naos October 21, 2023 09:20 — with GitHub Actions Inactive
@github-actions github-actions bot removed the deploy naos Request a deployment on naos label Oct 21, 2023
@bmesuere bmesuere added the deploy mestra Request a deployment on mestra label Oct 21, 2023
@bmesuere bmesuere temporarily deployed to mestra October 21, 2023 09:28 — with GitHub Actions Inactive
@github-actions github-actions bot removed the deploy mestra Request a deployment on mestra label Oct 21, 2023
Comment on lines 1 to 3
import { initFileViewers } from "file_viewer";

window.dodona.initPythiaSubmissionShow = initPythiaSubmissionShow;

// will automatically bind to window.iFrameResize()
require("iframe-resizer"); // eslint-disable-line no-undef
window.dodona.initFileViewers = initFileViewers;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since only the file viewer is left in this pack, wouldn't it be a good time to eliminate it and just add the file viewer init to the general submission pack and the initialisation code to the general feedback table renderer?

@jorg-vr jorg-vr merged commit 6e36633 into main Oct 23, 2023
11 of 13 checks passed
@jorg-vr jorg-vr deleted the feat/all-judges-debug branch October 23, 2023 08:06
@jorg-vr jorg-vr temporarily deployed to naos October 23, 2023 08:09 — with GitHub Actions Inactive
@jorg-vr jorg-vr temporarily deployed to naos October 23, 2023 12:09 — with GitHub Actions Inactive
@jorg-vr jorg-vr temporarily deployed to production October 23, 2023 12:12 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants