Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sorting for most recent submission per user #5022

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Oct 3, 2023

This pull request fixes broken sorting on submission listings when only viewing the most recent submission per user.

This was caused because the scope contains a group by call which doesn't always work as expected together with joins or order by statements.

  • Tests were added

@jorg-vr jorg-vr added the bug Something isn't working label Oct 3, 2023
@jorg-vr jorg-vr self-assigned this Oct 3, 2023
@jorg-vr jorg-vr marked this pull request as ready for review October 3, 2023 08:40
@jorg-vr jorg-vr requested a review from a team as a code owner October 3, 2023 08:40
@jorg-vr jorg-vr requested review from bmesuere and niknetniko and removed request for a team October 3, 2023 08:40
@jorg-vr jorg-vr merged commit ec81f58 into main Oct 3, 2023
13 checks passed
@jorg-vr jorg-vr deleted the fix/sorting-by-date branch October 3, 2023 12:05
@jorg-vr jorg-vr temporarily deployed to naos October 3, 2023 12:06 — with GitHub Actions Inactive
@jorg-vr jorg-vr temporarily deployed to production October 3, 2023 12:10 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants