Remove browser outline styling for focus-within on nav-tabs #4997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
requested review from
bmesuere and
chvp
and removed request for
a team
chvp
approved these changes
Sep 22, 2023
bmesuere
reviewed
Sep 22, 2023
|
I'll make it more specific |
jorg-vr
changed the title
bmesuere
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the outline styling applied by some browsers on tab links
focus-within is specifically applied by browsers to improve ux (https://developer.mozilla.org/en-US/docs/Web/CSS/:focus-visible). But it does not seem relevant in our case as we have custom styling to make UX clear for tabs.
Closes #4569