Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dragging create annotation button for padding pixels #4959

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Fix dragging create annotation button for padding pixels #4959

merged 2 commits into from
Sep 12, 2023

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Sep 12, 2023

I cannot explain why this change resolves the issue, but it does resolve it.

Closes #4941

@jorg-vr jorg-vr added the bug Something isn't working label Sep 12, 2023
@jorg-vr jorg-vr requested a review from a team as a code owner September 12, 2023 09:10
@jorg-vr jorg-vr self-assigned this Sep 12, 2023
@jorg-vr jorg-vr requested review from bmesuere and chvp and removed request for a team September 12, 2023 09:10
@chvp chvp changed the title Fix dragging create annpotation button for padding pixels Fix dragging create annotation button for padding pixels Sep 12, 2023
@chvp chvp added the deploy mestra Request a deployment on mestra label Sep 12, 2023
@chvp chvp temporarily deployed to mestra September 12, 2023 09:53 — with GitHub Actions Inactive
@github-actions github-actions bot removed the deploy mestra Request a deployment on mestra label Sep 12, 2023
@jorg-vr jorg-vr merged commit 326d9bd into main Sep 12, 2023
15 checks passed
@jorg-vr jorg-vr deleted the fix/drag-button-region branch September 12, 2023 11:31
@jorg-vr jorg-vr temporarily deployed to naos September 12, 2023 11:32 — with GitHub Actions Inactive
@jorg-vr jorg-vr temporarily deployed to production September 12, 2023 11:36 — with GitHub Actions Inactive
@jorg-vr jorg-vr mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chvp chvp chvp approved these changes

@niknetniko niknetniko niknetniko approved these changes

@bmesuere bmesuere Awaiting requested review from bmesuere bmesuere was automatically assigned from dodona-edu/review

Assignees

@jorg-vr jorg-vr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dragging of add annotation button only works if the mouse is far enough on it
3 participants
@jorg-vr @niknetniko @chvp