Reintroduce highlighting annotations on hover #4862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
added
the
enhancement
jorg-vr
requested review from
bmesuere and
niknetniko
and removed request for
a team
bmesuere
approved these changes
Aug 3, 2023
app/assets/javascripts/components/annotations/user_annotation.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Bart Mesuere <[email protected]>
niknetniko
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reintroduces highlighting of hovered annotations which was removed in #4771
I have taken a slightly different approach in the implementation, making it a bit more object orientated.
IsHovered is now a property of an annotation, instead of a global map.
To make this property reactive, using the existing state mechanism, I had to make annotations proper instances of a UserAnnotation or MachineAnnotation class. (Instead of just parsed json objects)