Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform less repository requests on the course page #4377

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Feb 2, 2023

This pull request avoids an N+1 amount of queries on a course page.
Selecting repositories was one of our most frequent queries, and this page was the biggest contributor.

The repository is used on this page to check if the user is repository admin and thus should see extra info about the exercise.
We could also avoid this by just limiting this feature to course admins.

@jorg-vr jorg-vr added the chore Repository/build/dependency maintenance label Feb 2, 2023
@jorg-vr jorg-vr self-assigned this Feb 2, 2023
@jorg-vr jorg-vr requested a review from a team as a code owner February 2, 2023 08:44
@jorg-vr jorg-vr requested review from bmesuere and chvp and removed request for a team February 2, 2023 08:44
@jorg-vr jorg-vr merged commit ebf8407 into develop Feb 2, 2023
@jorg-vr jorg-vr deleted the chore/less-repository-requests branch February 2, 2023 10:06
@bmesuere bmesuere added enhancement A change that isn't substantial enough to be called a feature and removed chore Repository/build/dependency maintenance labels Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A change that isn't substantial enough to be called a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants