exercise.js: remove jquery and convert to typescript #3930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hore/exercise-jquery-removal
9 tasks
BramDevlaminck
changed the title
…hore/exercise-jquery-removal
BramDevlaminck
changed the base branch from
develop
to
fix/empty-series-crash
BramDevlaminck
requested review from
bmesuere and
chvp
and removed request for
a team
niknetniko
requested changes
Sep 2, 2022
…estions by reviewers
|
This pull request introduces 1 alert when merging 6b15644 into 09f9867 - view on LGTM.com new alerts:
|
niknetniko
approved these changes
Sep 6, 2022
jorg-vr
approved these changes
Sep 6, 2022
bmesuere
approved these changes
Sep 8, 2022
chvp
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes jquery code from exercise.js
A feature that is removed with this rewrite is the animation for the pop-up when a submission fails, since I did not find a way to replace
<div>.show("fast");The animation that is removed was this one:
Screen.Recording.2022-08-31.at.14.21.41.mov
progress on #3590 .