-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let users sign in with a known provider before linking a new provider to the user #3670
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer this to be on a separate page or at least a modal instead of a flash/alert. This is an important action for the user and it feels somewhat wrong to stash this away like this.
If we make linking more transparent like this, it might also be a good idea to list the linked providers on the profile page of a user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Can you remove the drop shadow from the providers on the profile page? They look a lot like buttons now which they aren't. I think outlined-cards could work here, but I don't think I implemented them yet in the m3 refactor.
Co-authored-by: Charlotte Van Petegem <[email protected]>
This was one of the things I used to test these changes, but no reason to not commit it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I added a test I used to review this, and there was no reason to not commit it.
This pull request forces a user to confirm their identity before linking their new sign in method to an existing user.
The steps followed in the default scenario are as followed:
I also added the linked sign in methods to the user detail screen
Misc
Closes #3668 .