Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show submissions without course in the submission history of a submission without a course #3637

Merged
merged 1 commit into from
May 20, 2022

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented May 20, 2022

Closes #3544

@jorg-vr jorg-vr added the bug Something isn't working label May 20, 2022
@jorg-vr jorg-vr requested a review from a team as a code owner May 20, 2022 07:33
@jorg-vr jorg-vr requested review from bmesuere and chvp and removed request for a team May 20, 2022 07:33
@jorg-vr jorg-vr self-assigned this May 20, 2022
@chvp
Copy link
Member

chvp commented May 20, 2022

How does this interact with a page like https://dodona.ugent.be/nl/activities/1388161683/submissions/? When we re-use previous exercises for examinations/evaluations we use pages like that to check that students in the current course did not submit to a certain exercise. They could have done that both inside and outside of a course, so it is important that we can see both types of submissions.

@jorg-vr
Copy link
Contributor Author

jorg-vr commented May 20, 2022

This code does not change anything to that page.

The change in app/controllers/submissions_controller.rb only affects submission show

The change in app/models/submission.rb makes the in_course filter support nil values
I highly doubt that this page does any filtering on course, and other pages that do use the filter already should not have provided nil values before as these would have resulted in errors.

Thus no behavior other than on the submission show page

@jorg-vr jorg-vr merged commit c33c76a into develop May 20, 2022
@jorg-vr jorg-vr deleted the fix-submission-numbering branch May 20, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only show submissions without a course in the submission overview on the submission detail page
3 participants