Use send instead of play as hand in icon #3592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmesuere
added
the
enhancement
jorg-vr
approved these changes
May 3, 2022
niknetniko
approved these changes
May 3, 2022
chvp
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the icon that is used on the hand in button. This used to be a play icon, but since we now have the option to actually run code this might be confusing. The play icon was replaced by the send icon which better conveys the meaning of handing in. At the same time, the icon looks very similar to the play icon so this will probably not upset users.
The icon was centered visually and the tooltip text was updated.
For some reason, the tooltip text is also present in the JS translation file. I can't get it to update there, even when regenerating the file (and validating it gets regenerated). This key is never using in javascript so it shouldn't be an issue.