Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rights request: Show correct error message when motivation is not filled out #3274

Merged
merged 3 commits into from
Jan 6, 2022

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Jan 5, 2022

This pull request fixes a bug where the user was shown misleading information when he hadn't filled out a motivation message.

Right now the following message is shown:
image

The error message saying you already applied still appears when it should:
image

Closes #3124 .

@jorg-vr jorg-vr requested a review from a team as a code owner January 5, 2022 16:21
@jorg-vr jorg-vr requested review from bmesuere and niknetniko and removed request for a team January 5, 2022 16:21
app/views/rights_requests/new.html.erb Outdated Show resolved Hide resolved
@jorg-vr jorg-vr requested a review from bmesuere January 6, 2022 11:49
app/views/rights_requests/new.html.erb Outdated Show resolved Hide resolved
app/views/rights_requests/new.html.erb Outdated Show resolved Hide resolved
@niknetniko niknetniko added the bug Something isn't working label Jan 6, 2022
Co-authored-by: Niko Strijbol <[email protected]>
@jorg-vr jorg-vr requested a review from niknetniko January 6, 2022 14:26
@jorg-vr jorg-vr merged commit b2801d9 into develop Jan 6, 2022
@jorg-vr jorg-vr deleted the fix/3124-misleading-motivation branch January 6, 2022 14:56
@chvp
Copy link
Member

chvp commented Jan 9, 2022

I'm not sure this is the correct fix. I feel like the policy's create? should not return false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message when motivation is missing in rights request is very misleading
4 participants