Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force sass to compile imported files by making .scss extension explicit #3272

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Jan 4, 2022

This pull request fixes the issue that due to recent updates in sass, @import "xxxxx.css" are no longer compiled.
The specification can be found here: https://sass-lang.com/documentation/at-rules/import#plain-css-imports

The issue manifested itself in our case with the following error:

ActionView::Template::Error (Error: Undefined variable: "$development".
        on line 70:5 of app/assets/stylesheets/theme/theme-light.css.scss
        from line 11:9 of app/assets/stylesheets/base.css.scss
>> @if $development == true {

   ----^
):

Which is fixed by this pr

@jorg-vr jorg-vr requested a review from a team as a code owner January 4, 2022 13:08
@jorg-vr jorg-vr requested review from bmesuere and niknetniko and removed request for a team January 4, 2022 13:08
@jorg-vr jorg-vr merged commit 4da7391 into develop Jan 4, 2022
@jorg-vr jorg-vr deleted the fix/scss branch January 4, 2022 15:00
@niknetniko niknetniko added the bug Something isn't working label Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants