Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance annotation maximum length handling #3188

Merged
merged 4 commits into from
Oct 26, 2021

Conversation

niknetniko
Copy link
Member

@niknetniko niknetniko commented Oct 25, 2021

This pull request:

  • Increases max annotation length to 10.000 (this should still be well within the database column limit)
  • Adds client side limitations and validations: this should prevent you from typing too many characters, and if you do manage to type too many characters, the browser validations should be shown. Submitting empty annotations is also impossible now.
  • Shows a counter in the bottom right how many characters are used:

image

  • Tests were added

Closes #3164 .

@niknetniko niknetniko requested a review from a team as a code owner October 25, 2021 13:26
@niknetniko niknetniko requested review from bmesuere and chvp and removed request for a team October 25, 2021 13:26
@pdawyndt
Copy link
Contributor

Dodona style for large numbers: thin space instead of dots to separate the thousands.

@chvp chvp added the feature New feature or request label Oct 26, 2021
@niknetniko niknetniko merged commit cec9343 into develop Oct 26, 2021
@niknetniko niknetniko deleted the enhancement/annotation-length branch October 26, 2021 13:07
@bmesuere bmesuere added enhancement A change that isn't substantial enough to be called a feature and removed feature New feature or request labels Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A change that isn't substantial enough to be called a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message when annotation is too long should be clearer
4 participants