Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning about inaccessible activities to course admins on course show #3152

Merged
merged 7 commits into from
Oct 12, 2021

Conversation

chvp
Copy link
Member

@chvp chvp commented Oct 8, 2021

I opted not to add a quicklink to fix the situation, since the exercises could be in multiple repositories. If we really want to, we could add a quicklink if they're only from one repository, but that would make things more complex.

  • Tests were added

Closes #3135.

@chvp chvp added the bug Something isn't working label Oct 8, 2021
@chvp chvp requested a review from a team as a code owner October 8, 2021 14:33
@chvp chvp requested review from bmesuere and niknetniko and removed request for a team October 8, 2021 14:33
@chvp chvp force-pushed the fix/inaccessible-activity-warning branch from b16e65c to da1bec6 Compare October 8, 2021 14:34
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with not adding the quicklink, but the current error message doesn't really help the user. It provides no hint at how to fix this. Can we be more helpful? Some ideas:

  • Link to a docs page explaining private exercises and access management. (I don't know if we have a page like that)
  • Can we point them in the right direction of whom to request access to? (Not super easy I think?)
  • Add a link to the feedback form so we can help them

@chvp
Copy link
Member Author

chvp commented Oct 10, 2021

I agree with not adding the quicklink, but the current error message doesn't really help the user. It provides no hint at how to fix this. Can we be more helpful? Some ideas:

  • Link to a docs page explaining private exercises and access management. (I don't know if we have a page like that)

We don't.

  • Can we point them in the right direction of whom to request access to? (Not super easy I think?)

As hard as quicklinking the fix.

  • Add a link to the feedback form so we can help them

Sure, I'll do that.

@chvp chvp added the deploy mestra Request a deployment on mestra label Oct 10, 2021
@chvp chvp temporarily deployed to mestra October 10, 2021 16:55 Inactive
@github-actions github-actions bot removed the deploy mestra Request a deployment on mestra label Oct 10, 2021
@chvp chvp force-pushed the fix/inaccessible-activity-warning branch from 52bfc1e to 4373d6d Compare October 11, 2021 06:42
config/locales/views/courses/nl.yml Outdated Show resolved Hide resolved
app/controllers/courses_controller.rb Outdated Show resolved Hide resolved
@niknetniko niknetniko self-requested a review October 11, 2021 11:42
@chvp chvp requested a review from bmesuere October 12, 2021 07:47
@chvp chvp merged commit 4d37871 into develop Oct 12, 2021
@chvp chvp deleted the fix/inaccessible-activity-warning branch October 12, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always show a warning to course admins on course page if course does not have rights to some exercises
3 participants