Enable user search in evaluations #3058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimonDB
changed the title
TimonDB
requested review from
bmesuere and
chvp
and removed request for
a team
bmesuere
force-pushed
the
feature/user-search-evaluations
branch
from
c9814f4 to
0de1ed7
Compare
|
I rebased this on develop since #3056 was merged |
bmesuere
reviewed
Sep 2, 2021
| @@ -67,8 +70,9 @@ | |||
| </div> | |||
| </div> | |||
| </div> | |||
| <p class="help-block"></p> | |||
There was a problem hiding this comment.
This help paragraph was removed. @niknetniko can you remember if we used this for something?
There was a problem hiding this comment.
I think this was a mistake, and can be safely removed.
| @@ -0,0 +1,2 @@ | |||
| $("#evaluation-table-wrapper").html("<%= escape_javascript(render 'evaluation_table', feedbacks: @feedbacks, evaluation: @evaluation, users: @users) %>") | |||
There was a problem hiding this comment.
This could be optimized to only update the visible table, but it would leave it like this for now.
bmesuere
approved these changes
Sep 2, 2021
chvp
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables the searchbar in the evaluations.
Note: it needs #3056 to work correctly
Closes #2824.