Dodona 5.0 design tweaks #3024
Merged
Dodona 5.0 design tweaks #3024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmesuere
requested review from
niknetniko and
chvp
and removed request for
a team
|
I would limit the changes to these for now. Depending on feedback (and an actual material spec update) we can further update the colors in other places. The other proposed changes to the home page (more information about deadlines) are still in prototype and will be added in a later Dodona version. |
niknetniko
approved these changes
Aug 27, 2021
There was a problem hiding this comment.
The design tweaks are really nice, I look forward to using Dodona with these 👍
One question: is there intentionally no migration to remove the I need to learn how to read 😄color column from the course table or was that an oversight? (since the attribute in the model was removed)
chvp
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains a number of design tweaks to be released with Dodona 5.0. The goal is a friendlier, softer appearance.
Most of these changes were prototyped in #2760 and discussed in #2761.
List of changes:
The color field wasn't removed from the database yet to be able to revert this change if users protest. This is tracked in #3035.