Standardize column names in csv exports #3011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimonDB
commented
Aug 23, 2021
TimonDB
requested review from
bmesuere and
niknetniko
and removed request for
a team
chvp
requested changes
Aug 24, 2021
niknetniko
requested changes
Aug 24, 2021
There was a problem hiding this comment.
I think we need to standardize more:
- The series/course export use
User.human_attribute_namefor some column names, meaning they are translated and converted to "human" names, but not for all columns (e.g.labels). - The export and evaluation exports don't use the human_attribute stuff, so there the labels are as they are in the source code.
For example, the columns in the series export in Dutch are:
"Id","Gebruikersnaam","Voornaam","Familienaam","Email","labels","Reeks 7", ...
While the grade export is:
"id","username","last_name","first_name","full_name","email","labels","Total Score", ...
chvp
added
the
enhancement
So should we omit the |
chvp
approved these changes
Aug 25, 2021
niknetniko
approved these changes
Aug 25, 2021
bmesuere
requested changes
Aug 25, 2021
| @@ -192,15 +192,18 @@ def scoresheet | |||
| format.js | |||
| format.json | |||
| format.csv do | |||
| sheet = CSV.generate do |csv| | |||
| csv << [I18n.t('series.scoresheet.explanation')] | |||
There was a problem hiding this comment.
I don't think this and the other explanation string are used in other places, so they can be removed from the locales files.
bmesuere
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements a more consistent csv header format that at least contains the columns
id,username,last_name,first_name,emailandlabels.Closes #2801.