Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set current user's name as default value when creating a course #2967

Merged
merged 3 commits into from
Aug 10, 2021
Merged

Set current user's name as default value when creating a course #2967

merged 3 commits into from
Aug 10, 2021

Conversation

TimonDB
Copy link
Contributor

@TimonDB TimonDB commented Aug 5, 2021 •
edited
Loading

This pull request uses the current user's name as default value for the teacher when creating a new course. When copying an existing course, the current user's name and institution are used as default values.

Before:
Screenshot from 2021-08-05 17-15-18

After:
Screenshot from 2021-08-05 17-15-41

Closes #2660.

@TimonDB TimonDB requested a review from a team as a code owner August 5, 2021 15:26
@TimonDB TimonDB requested review from bmesuere and niknetniko and removed request for a team August 5, 2021 15:26
chvp
chvp reviewed Aug 5, 2021
View reviewed changes
Copy link
Member

@chvp chvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original issue also asked for the default to be changed when copying a course. Most copying is either done by the same author, where there would be no difference, or from a template course, where we definitely want to overwrite the teacher.

@bmesuere bmesuere marked this pull request as draft August 5, 2021 16:34
@chvp chvp added the enhancement A change that isn't substantial enough to be called a feature label Aug 5, 2021
@TimonDB TimonDB marked this pull request as ready for review August 9, 2021 07:46
@bmesuere bmesuere merged commit fde1d35 into develop Aug 10, 2021
@bmesuere bmesuere deleted the teacher-name-default-creating-course branch August 10, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chvp chvp chvp approved these changes

@niknetniko niknetniko niknetniko approved these changes

@bmesuere bmesuere bmesuere approved these changes

Assignees
No one assigned
Labels
enhancement A change that isn't substantial enough to be called a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set better default teacher name when creating a course
4 participants
@TimonDB @bmesuere @niknetniko @chvp