Re-implement util functions using URL API

[TimonDB]

This pull request re-implements the helper URL functions by using the URL API. Also, a test file for these functions is added.

Closes #2614 .

[chvp]

The issue also mentios the updateURL... functions. Is there a reason these weren't changed?

[TimonDB]

The issue also mentios the updateURL... functions. Is there a reason these weren't changed?

@chvp The updateURL... functions sometimes have only a pathname as URL argument (e.g. nl/submissions/53 was one I encountered), this resulted in an error (Error: Invalid URL) when trying to create the URL const url = new URL(_url)

[niknetniko]

The updateURL... functions sometimes have only a pathname as URL argument (e.g. nl/submissions/53 was one I encountered), this resulted in an error (Error: Invalid URL) when trying to create the URL const url = new URL(_url)

Is this used this way in a lot of places? Because if not, it might be worth to update the caller to provide the full URL, allowing us to also update the updateURL... functions, which would be nice.

[bmesuere]

I also agree with @niknetniko's comment

[TimonDB]

The updateURL... functions sometimes have only a pathname as URL argument (e.g. nl/submissions/53 was one I encountered), this resulted in an error (Error: Invalid URL) when trying to create the URL const url = new URL(_url)

Is this used this way in a lot of places? Because if not, it might be worth to update the caller to provide the full URL, allowing us to also update the updateURL... functions, which would be nice.

So far, I only found this to be true in the function loadfeedback in exercise.js. The other callers seem to provide a full URL

[chvp]

The easiest way to fix that there would probably be to add a base_submissions_url data attribute in the HTML. This can then be read in the setup function and used in place of the /submissions/ strings in the javascript file.

[bmesuere]

It would be reassuring if some jest tests were added covering those new functions. In addition, it would make sense to "port" these functions to typescript.

@chvp do we already have a file where we can place such helper functions in ts?

[chvp]

@chvp do we already have a file where we can place such helper functions in ts?

We don't, no.

[lgtm-com]

This pull request fixes 1 alert when merging cdafacc into b300479 - view on LGTM.com

fixed alerts:

• 1 for Incomplete string escaping or encoding