Rename annotations by users to comments in user interface #2953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chvp
force-pushed
the
feature/replace-annotation-naming-with-comment
branch
from
64ff618 to
0943886
Compare
In dutch "Opmerking" was used. I chose to keep the annotation naming around for the collection of machine-generated annotations and comments, since this made the naming clearer (IMO).
chvp
force-pushed
the
feature/replace-annotation-naming-with-comment
branch
from
0943886 to
9cd5650
Compare
chvp
requested review from
bmesuere and
niknetniko
and removed request for
a team
niknetniko
approved these changes
Aug 3, 2021
Co-authored-by: Niko Strijbol <[email protected]>
bmesuere
approved these changes
Aug 3, 2021
config/locales/js/nl.yml
Outdated
| @@ -109,16 +109,16 @@ nl: | |||
| copy-to-clipboard: Kopieer code naar klembord | |||
| user_annotation: | |||
| meta: "%{user} · %{time}" | |||
| send: 'Annoteren' | |||
| send: 'Plaatsen' | |||
There was a problem hiding this comment.
maybe this?
Suggested change
| send: 'Plaatsen' | |
| send: 'Opmerking toevoegen' |
There was a problem hiding this comment.
This gets a bit long for a primary button, IMO. Maybe just "Toevoegen"?
There was a problem hiding this comment.
Google Doc also has "Reactie toevoegen" as tooltip.
There was a problem hiding this comment.
This is not a tooltip though, it's used here (the "Annoteren" button):
There was a problem hiding this comment.
I changed it to "Toevoegen" for now, re-requesting review to make sure this is OK.
bmesuere
approved these changes
Aug 3, 2021
bmesuere
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dutch "Opmerking" was used. I chose to keep the annotation naming around for the collection of machine-generated annotations and comments, since this made the naming clearer (IMO).
Closes #1957.