Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add courses link to signed out navbar #2871

Merged
merged 1 commit into from
Jun 19, 2021
Merged

Conversation

bmesuere
Copy link
Member

This pull request adds a link to the courses listing to the signed out navbar. This page was only recently enabled for signed out users.

@bmesuere bmesuere added the enhancement A change that isn't substantial enough to be called a feature label Jun 19, 2021
@bmesuere bmesuere requested review from niknetniko and chvp June 19, 2021 17:50
@chvp chvp added the deploy mestra Request a deployment on mestra label Jun 19, 2021
@chvp chvp temporarily deployed to mestra June 19, 2021 17:54 Inactive
@github-actions github-actions bot removed the deploy mestra Request a deployment on mestra label Jun 19, 2021
Copy link
Member

@chvp chvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's quite a lot of items in the navbar now. This isn't necessarily a problem, but this is how it would look on a Samsung S9:
Screen Shot 2021-06-19 at 19 58 48

@bmesuere
Copy link
Member Author

Yes, I noticed as well, that's why I put the most important first (+ to get them indexed by Google). The alternative was to hide them in an overflow menu but I don't think it's worth the effort.

@bmesuere bmesuere merged commit 9f03720 into develop Jun 19, 2021
@bmesuere bmesuere deleted the change/add-courses-to-header branch June 19, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A change that isn't substantial enough to be called a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants