Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework how grading results are shown to students #2776

Merged
merged 9 commits into from
Jun 25, 2021

Conversation

niknetniko
Copy link
Member

This pull request adds a chevron to indicate there are score details:

image

It changes when open:
image

Closes #2743.

@niknetniko niknetniko requested review from bmesuere and chvp May 25, 2021 12:24
@niknetniko niknetniko added the feature New feature or request label May 25, 2021
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to work with a collapse here? If I'm correct, this is only shown to students on a page that is dedicated for this, so why not show everything by default?

@pdawyndt
Copy link
Contributor

@bmesuere The scores are also shown to the students in the header of the submission and there it seems OK to collapse the scores. But I agree that collapsing seems usesless on a dedicated page. Also, the first row of the table shows the total score but this repeated information (it is already next to the chevron that was clicked) and might be removed.

Is the option to expand also provide in the special case (but an option that seems a reasonable choice) where only the total score is visible for the student?

@niknetniko niknetniko marked this pull request as draft May 25, 2021 15:19
@chvp chvp added enhancement A change that isn't substantial enough to be called a feature and removed feature New feature or request labels Jun 16, 2021
@niknetniko niknetniko force-pushed the feature/discoverable-score-details branch from 3061f2e to 88b395a Compare June 24, 2021 15:48
@niknetniko
Copy link
Member Author

As discussed, the evaluation overview for students has been modified to always show the grades if the evaluation is graded:
image

For the total score row:

  • When the total score is not visible, you see a "-" with the shown tooltip.
  • When the evaluator didn't grade your submission for some reason, you'll get "- / [max, e.g. 10]"
  • When the exercise isn't graded, you get "Geen"
  • The subtext is the old text about the annotations / no valid submission.

If the evaluation is not graded or all grades are private, there is no change.

Another suggestion was applying #1957, but I think that's out of scope for this PR; we probably should change this all at once.

@niknetniko niknetniko marked this pull request as ready for review June 24, 2021 16:02
@niknetniko niknetniko requested review from bmesuere and chvp June 24, 2021 16:02
@pdawyndt pdawyndt assigned pdawyndt and unassigned pdawyndt Jun 24, 2021
@bmesuere bmesuere added the deploy mestra Request a deployment on mestra label Jun 24, 2021
@bmesuere bmesuere temporarily deployed to mestra June 24, 2021 16:11 Inactive
@github-actions github-actions bot removed the deploy mestra Request a deployment on mestra label Jun 24, 2021
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I played around with this on mestra and I think it's a great improvement. Some smaller remarks.

  • The order of the exercises in the overview does not match the order in the evaluation.
  • If one of multiple items is hidden, the sum of the sub scores doesn't match with the total score. Not sure if we want to fix it. I would guess most teacher will show all or nothing. Potentially we could add "niet alle deelscores werden vrijgegeven" to the total row if this is the case?
  • If an exercises was not a graded exercise, I would not show "geen", but also a dash. In that case, maybe also put something else instead of "totaalscore"?
  • Since we have enough space, convert the "no annotations" into a longer sentence?
  • Is there a reason why you didn't put "score" in the table header for that column?
  • "De totaalscore werd niet vrijgegeven" is maybe a little clearer than "De totaalscore is niet zichtbaar"?
  • I wasn't sure about the align-top of the score and chevron. At first, I thought that middle looked better, but then I realized that they are aligned with the name of the score item (when using top) which probably looks better if there's a multiline description. That reason isn't valid for the chevron, since it applies to the entire row, but then is wouldn't align with the top-aligned score. So the current solution probably is the best.
  • I would emphasize the total row even more. On the left of the table, this is clear already, but when looking at the right, the totals aren't standing out. One way to do this is by making them bold, eg:
    image

@niknetniko niknetniko requested a review from a team as a code owner June 25, 2021 09:37
config/locales/views/evaluations/en.yml Outdated Show resolved Hide resolved
@chvp chvp added the deploy mestra Request a deployment on mestra label Jun 25, 2021
@chvp chvp temporarily deployed to mestra June 25, 2021 14:38 Inactive
@github-actions github-actions bot removed the deploy mestra Request a deployment on mestra label Jun 25, 2021
@chvp chvp changed the title Add chevron to indicate there are score details Rework how grading results are shown to students Jun 25, 2021
@niknetniko niknetniko merged commit 0896a64 into develop Jun 25, 2021
@niknetniko niknetniko deleted the feature/discoverable-score-details branch June 25, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A change that isn't substantial enough to be called a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve discoverability of grading details for students
4 participants