-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add series visualisations #2598
Conversation
Changes that should still be made: General
Violin
Stacked Status
Timeseries
|
Some issues: Authorization Exercise order minor problem: typescript error |
All strings now use proper translations. |
Regarding show statistics button:
|
Some more problems that need fixing: Timeseries
Violin
Stacked status
|
|
TODOS
|
Authorization has been implemented, but is turned off. This will need to be turned back on before deploying. |
This pull request introduces 5 alerts when merging d011f84 into 001147f - view on LGTM.com new alerts:
|
This pull request introduces 5 alerts when merging 9ac7488 into 001147f - view on LGTM.com new alerts:
|
TODOS
|
This pull request introduces 5 alerts when merging dbfb355 into 55ef170 - view on LGTM.com new alerts:
|
This pull request introduces 5 alerts when merging f6e9f59 into 55ef170 - view on LGTM.com new alerts:
|
This pull request introduces 5 alerts when merging c40fb20 into 55ef170 - view on LGTM.com new alerts:
|
52603bf
to
3358cbe
Compare
config/routes.rb
Outdated
end | ||
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1689256
to
b617d30
Compare
aa586c1
to
ce0cca6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end | ||
|
||
def series_visualisation(visualisation) | ||
series = Series.find(params[:series_id]) if params.key?(:series_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
series = Series.find(params[:series_id]) if params.key?(:series_id) | |
series = Series.find(params[:series_id]) |
By removing the if, we'll get 404 on a missing param, instead of a 500. (Technically it should probably be a 422, since the resource is found, but a param is missing, but I don't think we do that anywhere for GET requests)
I added a title attribute to the toggle buttons containing the same string as the title shown above the graph. I didn't use bootstrap tooltips because these use the |
This pull request adds a number of visualisations to the course page. All of the visualisations are aimed at showing the status of the exercises in a single series. The visualisations are only visible for course admins.
Graphs
Tries needed to get it right
The first graph shows the distribution of number of submissions for each of the exercises. The average number of tries is shown with a dot and explicitly shown at the right. A mouseover shows the exact values.
For now, the x-axis is always limited to 20. User with more submissions are binned in that last bin.
Distribution of the submission statuses
The second graph shows a bar chart for each exercise showing the distribution of the status of all submitted solutions. This can be useful to see if the time or memory limit might be too strict. A tooltip shows the exact values
When do students practice
This graph is unfinished. It needs better (dynamic) binning to be useful. It is therefore hidden in the final version of this PR.
When did the students get it right
This graph shows the percentage of students that have submitted a correct solution to an exercise over time. It can be useful to monitor the progress of students after a lab session or the amount of work that was spent just before the deadline. A tooltip shows the exact percentages.
Next steps
There are a number of follow up issues that would improve this first version.
div
that's positioned over the bottom of the svg. Reimplement series graph legends in html #3019Closes #1835, closes #1013, closes #984